Mark the value param with const modifier in the ext/uri write handler#22274
Merged
Conversation
kocsismate
force-pushed
the
uri-write-value-const
branch
from
4c75901 to
6b93f5f
Compare
TimWolla
reviewed
Jun 13, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Please also constify php_uri_property_write_helper(). But LGTM other than that.
TimWolla
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a question/proposal carved out from #22173 (comment). Is it OK to make this API break?